<html>
<head><meta charset="utf-8"><title>review for #70551? · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html">review for #70551?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200954552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/200954552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#200954552">(Jun 15 2020 at 22:40)</a>:</h4>
<p>Hi, could someone review <a href="https://github.com/rust-lang/rust/pull/70551">https://github.com/rust-lang/rust/pull/70551</a>. I'm afraid it will bitrot.</p>



<a name="200956248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/200956248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#200956248">(Jun 15 2020 at 23:04)</a>:</h4>
<p>i think it's better to resolve the conflict first</p>



<a name="200957153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/200957153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#200957153">(Jun 15 2020 at 23:18)</a>:</h4>
<p><span class="user-mention" data-user-id="198054">@mark-i-m</span>: looks good to me.</p>



<a name="200958051"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/200958051" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#200958051">(Jun 15 2020 at 23:29)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span>  Thanks! I rebased and squashed some commits</p>



<a name="200958188"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/200958188" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#200958188">(Jun 15 2020 at 23:31)</a>:</h4>
<p>will r=varkor when ci passes if they don't <span aria-label="slight smile" class="emoji emoji-1f642" role="img" title="slight smile">:slight_smile:</span></p>



<a name="201157744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/201157744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#201157744">(Jun 17 2020 at 15:28)</a>:</h4>
<p><span class="user-mention" data-user-id="121053">@varkor</span> friendly nudge :) Thanks again for reviewing!</p>



<a name="201162294"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/201162294" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#201162294">(Jun 17 2020 at 15:59)</a>:</h4>
<p><span class="user-mention" data-user-id="198054">@mark-i-m</span>: oh, sorry, I thought you would just r=varkor when it was passing CI. Approved now!</p>



<a name="201166990"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/201166990" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mark-i-m <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#201166990">(Jun 17 2020 at 16:36)</a>:</h4>
<p>Ah, thanks! I don't have bors permissions</p>



<a name="201531928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/review%20for%20%2370551%3F/near/201531928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/review.20for.20.2370551.3F.html#201531928">(Jun 21 2020 at 12:16)</a>:</h4>
<p>Whoops, didn't realise that, sorry!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>